forked from microsoft/autogen
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI API key format validation #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklysze
changed the title
Updated to expand acceptable OpenAI API key format
OpenAI API key format validation update
Sep 23, 2024
marklysze
changed the title
OpenAI API key format validation update
OpenAI API key format validation
Sep 23, 2024
0xdre
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested this PR within my use case, where I run Autogen using uvicorn. The API key validation warning issue was resolved, and everything works as expected now. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
OpenAI's API key has changed in format recently and the validation function in OpenAI doesn't accurately validate the format.
OpenAI has not published the format of the key, so information gathered so far is that it can start with:
sk-
sk-proj-
sk-None-
sk-svcaat-
This is followed by segments of alphanumeric characters (including underscores) separated by dashes.
As the exact format is not defined, the regular expression in the validation function will be expanded to support keys:
sk-
The tests have been updated.
Related issue number
Closes #26
Checks