forked from microsoft/autogen
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bren #90
Open
BrennanOwYong
wants to merge
11
commits into
main
Choose a base branch
from
bren
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bren #90
+176
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 4, 2024 14:06
— with
GitHub Actions
Waiting
Thanks for the PR. I see that there are code formatting issues. Could you please run pre-commit to fix them? Thank you! |
@BrennanOwYong Thanks for the PR. @LinxinS97 @LeoLjl @JieyuZ2 might be interested in this PR as they have worked in similar directions. Would you like to discuss this together on Discord? If so, could you please share your Discord name? @BrennanOwYong |
Bingus Bongus |
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 13:28
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 14:56
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 14:56
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 14:56
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 14:56
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 14:56
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:05
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:11
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
BrennanOwYong
requested a deployment
to
openai1
November 5, 2024 15:27
— with
GitHub Actions
Waiting
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
* Cancellation for model client autogenhub#90 * format * Use future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I see that the code that handles the activation of nested chats only accepts the a Callable that only takes 1 parameter, the sender
elif isinstance(trigger, Callable): rst = trigger(sender) assert isinstance(rst, bool), f"trigger {trigger} must return a boolean value." return rst
I want to give devs more flexibility to decide when to have Agents initiate nested chats.
EG.1 (Poor example due to code runner already existing as a part of some old version of GPT)
the user proxy tells a code_writer agent that they want a script for something. The code_writer can write the script, but to test that script it needs a nested chat with a code_runner agent (without LLM, of course) to verify the output and show the user. Sure, there is an option for a group chat where conversation patterns are cyclic (as below)User_Proxy > Code_Writer > Code_Tester: Rinse and Repeat
But end-users might want the experience to be more conversational, where they can converse with the Code_Writer a little more before sending it to do the work.
EG.2
Let's say I want to know how which farmlands to invest in based on satellite images and historical weather conditions. I would have an agent to plan out investment strategies (Planner_Agent) speaking to an Executor_Agent agent that will create the automation to do the calculations based on those strategies. However, the agent that develops the straategy realises that its data is incomplete, something the developer did not know. Therefore, since the developer didn'tknow this, the agent workflow they created only has 2 agents, the Planner_Agent and the Executor_Agent. The developer does not know it yet, but the Execturo_Agent will need a Data_Acquisition_Agent to go out and collect more data. I'm basically refering to a system that can identify its own limitations and write add-ons for itself.
The example above is something I personaly faced because i wanted to leverage Autogen's pre-existing support for code execution and peer-to-peer to build an intelligent hive that would take an instruction from the top and autonomously "run-wild" to get it done.
One a personal note, I feel like "pre-setting" the conversation patterns during runtime makes applications built with it feel more like a Zapier automation workflow instead of an intelligent app that truly makes use of the potential of LLMS. To me, it is comparable to giving someone a Jeep and only telling them to drive it on nice flat paved roads when a Jeep is already built to handle rough terrain.
Related issue number
Checks