Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more faiss index algorithms and refactor the interface #75

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

cheungdaven
Copy link
Collaborator

@cheungdaven cheungdaven commented Oct 11, 2024

Description

[Provide a brief description of the changes in this PR]
Support more faiss index algorithms.
refactor the argument interface.

Related Issue

[Link to the related issue, if applicable]

Type of Change

  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding style
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added appropriate comments to my code, particularly in hard-to-understand areas

Additional Information

[Any additional information, configuration, or data that might be necessary to reproduce the issue or test the PR]

Screenshots (if appropriate)

[Add screenshots to help explain your changes]

Performance Impact

[Describe any performance impact this change may have]

Backwards Compatibility

[Describe any backwards incompatible changes and how you've addressed them]

Dependency Changes

[List any new dependencies introduced or removed]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@shreyash2106 shreyash2106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Shuai!

@tonyhoo tonyhoo closed this Oct 14, 2024
@tonyhoo tonyhoo reopened this Oct 14, 2024
@cheungdaven cheungdaven reopened this Oct 14, 2024
@cheungdaven cheungdaven reopened this Oct 14, 2024
Copy link

Job PR-75-66f83c8 is done.
Docs are uploaded to https://d1at46xkvcde0c.cloudfront.net/PR-75/66f83c8/index.html

@cheungdaven cheungdaven requested review from tonyhoo and removed request for FANGAreNotGnu October 14, 2024 21:59
@cheungdaven cheungdaven merged commit 040a566 into autogluon:main Oct 14, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants