Add functionality to use Generator only without retrieved context #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheungdaven
reviewed
Oct 14, 2024
|
|
||
| ```python | ||
| retriever: | ||
| retriever_top_k: 20 |
There was a problem hiding this comment.
If we set retriever_top_k in the config to 0 without setting agrag.retriever_module.top_k = 0, will it work?
There was a problem hiding this comment.
Yeah you can do either one.
|
Job PR-77-b07078c is done. |
|
Job PR-77-430b8f9 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives the user the option to use the generator model only without any retrieved-context from their pre-processed documents.
Related Issue
#76
Type of Change
Checklist
Additional Information
[Any additional information, configuration, or data that might be necessary to reproduce the issue or test the PR]
Screenshots (if appropriate)
[Add screenshots to help explain your changes]
Performance Impact
[Describe any performance impact this change may have]
Backwards Compatibility
[Describe any backwards incompatible changes and how you've addressed them]
Dependency Changes
[List any new dependencies introduced or removed]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.