Skip to content

Commit

Permalink
Restore </li>
Browse files Browse the repository at this point in the history
edit: although tag technically creates a closed tag by default, leaving in the </li> doesn't seem to hurt. However we should actually use content_tag instead

show: equal number of opening and closing tags, presumably it matches something
  • Loading branch information
damianhxy committed Jun 20, 2022
1 parent 0a1efee commit e704b09
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/views/assessments/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<% [ "basic", "handin", "penalties", "problems", "advanced" ].each do |tab_name| %>
<%= (tab_name == params[:active_tab]) ? tag(:li, {:class => "active tab"}) : tag(:li, class: :tab) %>
<%= link_to tab_name.titleize, "#tab_#{tab_name}" %>
</li>
<% end %>
</ul>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/assessments/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
locals: { submission: submission,
download_access: download_access } %>
<% end %>
<%= link_to "See all submissions", {:action => "history"} %>
<%= link_to "See all submissions", {:action => "history"} %></li>

<% end %>
</div>

0 comments on commit e704b09

Please sign in to comment.