Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Submission doesn't properly display fractional grades. #1314

Closed
MilesConn opened this issue Apr 5, 2021 · 4 comments · Fixed by #1324
Closed

Annotate Submission doesn't properly display fractional grades. #1314

MilesConn opened this issue Apr 5, 2021 · 4 comments · Fixed by #1324

Comments

@MilesConn
Copy link

This is CMU's Autolab I'm a TA.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to Annotate a Submission
  2. Assign a non integer grade ie -.5 to Style.

Current behavior
Style gets marked as an integer rounded down in the UI but the fraction correctly shows when I go to edit and in the final grade.

Expected behavior
The number should be correct.

Screenshots
Screenshot_20210405_005625
Screenshot_20210405_005600
Screenshot_20210405_005543

@oliverli
Copy link
Contributor

oliverli commented Apr 6, 2021

Hi Miles, thanks for reporting the bug! I have verified and replicated it, and am now looking into the issue and looking to push a fix

@oliverli
Copy link
Contributor

Just checking in again since I remember you verbally told me the issue hasn't yet been fully resolved - where does the issue still persist?

@oliverli oliverli reopened this May 21, 2021
@MilesConn
Copy link
Author

Yeah the issue is still there I believe. As you can see in the top right.

image

@xinyis991105
Copy link
Contributor

Hi! I was able to replicate this issue. The interesting thing is that when you make a change to your annotation, it displays incorrectly. But if you refresh the page, it displays ok. I will soon attach a PR to fix this. Thanks for confirming with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants