Properly display fractional grades in annotations #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhuangwq
approved these changes
Apr 11, 2021
amartinez116
pushed a commit
that referenced
this pull request
May 2, 2021
* Properly display fractional grades in annotations * Add switch to neutral for zero scores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always a good idea to reason about whether a value is actually an integer before using
parseInt!Motivation and Context
Fixes #1314
Also fixes another UI/UX I found where annotations with no changes to scores are not properly reflected using the
neutralclassHow Has This Been Tested?
Tested by creating an annotation with -1.6, 0, 0.5, and 1.6 points
Types of changes
Checklist: