Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-based versioning for dropdown version selection #1729

Closed
michellexliu opened this issue Jan 29, 2023 · 3 comments · Fixed by #1840
Closed

File-based versioning for dropdown version selection #1729

michellexliu opened this issue Jan 29, 2023 · 3 comments · Fixed by #1840
Assignees

Comments

@michellexliu
Copy link
Contributor

michellexliu commented Jan 29, 2023

When switching versions of a submission via the dropdown, "lock" it to the same file (if the file exists in the other submission), similar to how the file stays when switching versions with the arrow. Possibly add some way of indicating which submission versions contain the file

@damianhxy
Copy link
Member

@michellexliu I believe this is the current functionality?

For reference: #1503
My code determines the submission versions containing the current file and the arrow buttons jump to the correct header_position.

@michellexliu
Copy link
Contributor Author

Oh hmm good catch; I just checked and the selected file persists with the arrows. However, if you select a different file & select the new version with the dropdown (even if it has the same file available), the file gets switched to the default one.

I'll update the issue to reflect this.

@michellexliu michellexliu changed the title File-based versioning File-based versioning for dropdown version selection Jan 30, 2023
@damianhxy
Copy link
Member

damianhxy commented Jan 30, 2023

Hmm, that was something I considered implementing. It shouldn't be too hard to lock it to the same file when switching, although the drop-down might not have space to indicate versions with the file.

Plan

  1. Mark versions with file with an asterisk (*)
  2. If clicking on a version with an asterisk, jump straight to the file
  3. When switching between files, update the select list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants