-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission Version Switching #1503
Conversation
7b07d12
to
03da4d9
Compare
@damianhxy could you elaborate what was changed since we last discussed? At the same time I do have concerns that people might get confused by the [# student / total students] and version / # of versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally it looks good to me as described. I would just like some clarification and I think we are good to go.
The main difference is that the arrow buttons now work on a per-file basis. Previously, they would simply bring you to the next or previous version (and reset you to Now, the arrow buttons operate on a per-file basis. That is to say, clicking them will bring you to the next or previous version that contains the file (i.e. the same filepath). They will also now be grayed out when there is no older / newer version containing the file. How this works is that when viewing a file (e.g. from an archive), we look through the other versions and search each one for the same filepath. If it exists, we take note of the Note however that the functionality of the version dropdown remains unchanged, and using it to change versions will reset you to
Perhaps we can attach a |
I think adding the title would address the issue - good enough fix for now, because I think we might want to reimagine this page in the future. At the same time I tested this
It works as mentioned. It doesn't skip if I submitted a single file, and then a tar file afterwards however. But I guess that's an okay behavior. (i.e. hello.c, then i submit hello.tar containing abc.c & def.c) |
Yup, I don't expect the handin format to change across versions after all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation and Context
When investigating AIVs, instructors might want to track changes to a specific file across the different versions of a student's submission. This PR adds buttons to enable instructors to easily switch between the different versions.
Note: For single file handin formats, the arrows will effectively work to cycle through the versions.
How Has This Been Tested?
handin.tar
hello.tar
, as well as modified versions (e.g. remove files, add files).c
,.pdf
) that the arrow buttons serve to enumerate through the versionsTypes of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting