-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options to new API scopes field #1030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some features may not be available.
…oss the whole site.
… and have expected behaviors across all forms.
Fix issue 667
Form fixes jacob
* revert to mysql, and properly comment unused section * correct order of config initilization
* Remove disabled fields in create course user datum (#877) * removes a check that stops annotations with the same submission and problem number from being added * removed annotation updates that expect there to be a single annotation for each submission and problem * Untangled gradebook and annotations, so gradebook isn't affected by annotation scores and scores can take any value. * Begun rollout of our Slack and updated logo * Updated main url * Fixed Add-To-Slack btn * fixed annotation deletion also deleting score bug and added a note for instructors * reverted db migration changes * Added point deductions on annotations * Problem and Score box now shows after update annotation * Problem field shows in editAnnotation * Worked on properly updating scores * removes a check that stops annotations with the same submission and problem number from being added * removed annotation updates that expect there to be a single annotation for each submission and problem * Untangled gradebook and annotations, so gradebook isn't affected by annotation scores and scores can take any value. * Begun rollout of our Slack and updated logo * Updated main url * Fixed Add-To-Slack btn * fixed annotation deletion also deleting score bug and added a note for instructors * Added point deductions on annotations * reverted db migration changes * Problem and Score box now shows after update annotation * Problem field shows in editAnnotation * Worked on properly updating scores * Changed highlight color for lines > 80ch * Code highlights now include all characters * Added feature to minimize code annotations * Changed minimize button to material-icon 'remove' in code anns. * Annotations are now minimized by default * Removed debugging print statements * Removed more print statements * Fixed no-click error, added checks for scores/gen probs * removes a check that stops annotations with the same submission and problem number from being added * removed annotation updates that expect there to be a single annotation for each submission and problem * Untangled gradebook and annotations, so gradebook isn't affected by annotation scores and scores can take any value. * Begun rollout of our Slack and updated logo * Updated main url * Fixed Add-To-Slack btn * fixed annotation deletion also deleting score bug and added a note for instructors * Added point deductions on annotations * reverted db migration changes * Problem and Score box now shows after update annotation * Problem field shows in editAnnotation * Worked on properly updating scores * Untangled gradebook and annotations, so gradebook isn't affected by annotation scores and scores can take any value. * Begun rollout of our Slack and updated logo * Updated main url * Fixed Add-To-Slack btn * fixed annotation deletion also deleting score bug and added a note for instructors * reverted db migration changes * Added point deductions on annotations * Worked on properly updating scores * Changed highlight color for lines > 80ch * Code highlights now include all characters * Added feature to minimize code annotations * Changed minimize button to material-icon 'remove' in code anns. * Annotations are now minimized by default * Removed debugging print statements * Removed more print statements * Fixed no-click error, added checks for scores/gen probs * Removed minimize button in PDF anns * Replaced submit button that was deleted during rebase
* decoupled annotations and gradebook again * brought back head :no_content
* bolded notice that annotations and gradebook are decoupled * added annotation collapse and expand buttons
Integrating a few of cg2v's improvements: When exceptions occur processing handins or autograde output, send the exception to ExceptionNotifier and the course log. Otherwise, the only notification in some cases goes to the student, who gets a bland "submission failed" flash that they probably ignore.
Integrating one of cg2v's improvements: After set_course renders the 404 page inline, it needs to immediately return since any future exception will try to redirect or render triggering a double render error
* Statistics hotfix for excluding students. * removed byebug_history and added to gitignoe
API v1 hotfix (fix regrade functions)
* retry http ops in tango_client * sleep between retries
* only shows annotation when the grading deadline has passed or user is an instructor * comments are important
* Added error-checking to annotations_controller * Added error-handling to problems_controller * Added error checking to courses_controller.rb * Added error handling to submissions_controller * Removed unnecessary error handling, fixed typos * Removed unnecessary error handling in problems_controller * Removed trivial error handling in courses_controller * Removed trivial error checking in annotations_controller * removed a few extraneous error handlers
* remove restraint that submissions can only be seen by the submitting app * bump version to 2.2.1
devanshk
approved these changes
Apr 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
damianhxy
approved these changes
May 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - text agrees with doorkeeper config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.