Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for malformed handins early #1138

Merged
merged 2 commits into from
May 3, 2020
Merged

Check for malformed handins early #1138

merged 2 commits into from
May 3, 2020

Conversation

oliverli
Copy link
Contributor

validateHandin_forHTML needs to check for malformed handins or missing handin files before dereferencing params[:submission]

For the original commit see cg2v@df5e132

Addresses #1134, but we should also look into why dragging and dropping files sometimes fail to upload correctly

@oliverli oliverli requested a review from fanpu April 28, 2020 03:28
fanpu
fanpu approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@fanpu fanpu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also just made a small change from tabs to spaces as it was causing indentation issues as seen from gh

@fanpu fanpu merged commit 24e739e into master May 3, 2020
@oliverli oliverli deleted the malformed-handin-check branch May 3, 2020 21:13
@fanpu fanpu mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanpu fanpu fanpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverli @fanpu