Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handler for invalid tar files #1322

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add exception handler for invalid tar files #1322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/controllers/submissions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,13 @@ def view

# Pull the files with their hierarchy info for the file tree
if Archive.archive? @filename
@files = Archive.get_file_hierarchy(@filename).sort! { |a, b| a[:pathname] <=> b[:pathname] }
@header_position = params[:header_position].to_i
begin
@files = Archive.get_file_hierarchy(@filename).sort! { |a, b| a[:pathname] <=> b[:pathname] }
@header_position = params[:header_position].to_i
rescue
flash[:error] = "Could not read archive."
redirect_to [@course, @assessment] and return false
end
else
@files = [{
pathname: @filename,
Expand Down