Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime picker result display fix #1359

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Conversation

fanpu
Copy link
Contributor

@fanpu fanpu commented May 30, 2021

Description

Addresses #1357

Motivation and Context

The bug comes from the fact that altInput is specified, but the formatting is not specified. Usually one would do it with altFormat, but in this case we already have a template from @oliverli that also shows the time zone as well, so I decided to go with that to be more descriptive and consistent.

How Has This Been Tested?

Announcement start/end times now render properly, now with the time zone being specified as well

Screenshot_select-area_20210530012825

I have also checked that handin start/end times datepicker values, and extension times still render properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@fanpu fanpu changed the title Datetime picker display fix Datetime picker result display fix May 30, 2021
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally.
LGTM!

@fanpu
Copy link
Contributor Author

fanpu commented Jun 9, 2021

I will look at this re:Chaskiel's email on the scheduler's datepicker having issues

@victorhuangwq
Copy link
Contributor

Hi @fanpu do you think this could be merged in? Seems like the recent issue with the scheduler not working could be fixed by this PR.

@fanpu
Copy link
Contributor Author

fanpu commented Sep 7, 2021

In the ticket it seems like this is not just a display issue, but also impacts whether the values are actually persisted. We'll need to test on that front as well

@fanpu
Copy link
Contributor Author

fanpu commented Sep 7, 2021

This PR appears to fix the issue:

2.6.6 :001 > Scheduler.last
  Scheduler Load (0.1ms)  SELECT  "scheduler".* FROM "scheduler" ORDER BY "scheduler"."id" DESC LIMIT ?  [["LIMIT", 1]]
 => #<Scheduler id: 1, action: "Test", next: "2021-09-08 15:53:00", interval: 10, course_id: 1, created_at: "2021-09-07 15:53:39", updated_at: "2021-09-07 15:53:39"> 

On master branch nil is set on the [next] field instead

@fanpu fanpu merged commit 554e2f5 into master Sep 7, 2021
@fanpu fanpu deleted the datetime-picker-display-fix branch September 7, 2021 15:55
ugogon pushed a commit to ugogon/Autolab that referenced this pull request Sep 21, 2021
* Specify altFormat when we use altInput

* show timezone for datepicker output
ugogon pushed a commit to ugogon/Autolab that referenced this pull request Oct 13, 2021
* Specify altFormat when we use altInput

* show timezone for datepicker output
ugogon pushed a commit to ugogon/Autolab that referenced this pull request Oct 13, 2021
* Specify altFormat when we use altInput

* show timezone for datepicker output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants