-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datetime picker result display fix #1359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Locally.
LGTM!
I will look at this re:Chaskiel's email on the scheduler's datepicker having issues |
Hi @fanpu do you think this could be merged in? Seems like the recent issue with the scheduler not working could be fixed by this PR. |
In the ticket it seems like this is not just a display issue, but also impacts whether the values are actually persisted. We'll need to test on that front as well |
This PR appears to fix the issue:
On master branch nil is set on the [next] field instead |
* Specify altFormat when we use altInput * show timezone for datepicker output
* Specify altFormat when we use altInput * show timezone for datepicker output
* Specify altFormat when we use altInput * show timezone for datepicker output
Description
Addresses #1357
Motivation and Context
The bug comes from the fact that altInput is specified, but the formatting is not specified. Usually one would do it with altFormat, but in this case we already have a template from @oliverli that also shows the time zone as well, so I decided to go with that to be more descriptive and consistent.
How Has This Been Tested?
Announcement start/end times now render properly, now with the time zone being specified as well
I have also checked that handin start/end times datepicker values, and extension times still render properly.
Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.