Fixed overlapping footer in 500 error page #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverli
reviewed
Sep 8, 2021
.bundle/config
Outdated
| @@ -0,0 +1,2 @@ | |||
| --- | |||
| BUNDLE_BUILD__MYSQL2: "--with-ldflags=-L/usr/local/opt/libmysqlclient/lib --with-cppflags=-I/usr/local/opt/libmysqlclient/include" | |||
There was a problem hiding this comment.
was this file autogenerated?
There was a problem hiding this comment.
Yes— I'm not too sure how it got there; should I remove this and add it to the .gitignore?
There was a problem hiding this comment.
Sorry for the late reply! Yep, let's remove and gitignore it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a duplicate
id="footer"in a div above the footer on the 500 error page and adds the "Questions or problems? Please contact us" section to the 404 error page.Motivation and Context
Removing the duplicate
idaddresses #1287, thus making the footer appear properly on the 500 error page and allowing the other div to be readable/usable. Adding the "Questions or problems? Please contact us" section to the 404 error page makes it more consistent with the 500 error page and provides an additional avenue for a user to contact us about an issue/bug.Before:
Updated div:
How Has This Been Tested?
Footer and "Questions or problems?..." div both appear properly on desktop, mobile, and tablet views.
Types of changes
Checklist:
Other issues / help required
It seems that my local configuration Autolab generated some extra files (
config/initializers/devise.rb.bak,config/initializers/devise.rb-e, and.bundle/config) and also modified thedb/schema.rbfile... I've since reverted most of these changes, but I'm still unsure why this happened / how to prevent this from happening again.I was also running into issues with my
bundle installwhen I was setting up Autolab and couldn't get it to work until I changed the versions in some of the Gemfile.lock dependencies, but I'm not sure if these version changes are something that needs to be fixed in Autolab or if it was just an issue with my installation. For context, I am on macOS 11.0.1, ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin20], rake version 13.0.6, and set up my local Autolab sometime in early June.