Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary date picker related code change #1377

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

xinyis991105
Copy link
Contributor

Description

This PR removes unnecessary date picker related code change.

Motivation and Context

#1376

How Has This Been Tested?

rails s and visit localhost:3000
Choose a course of your choice and click the upper right Manage Course. Click Course Settings to edit it.
If you scroll down to start and end date now, they should display appropriate date information. Date picker also works as expected, as below.
Screen Shot 2021-09-11 at 11 08 53 PM
The previous error was likely due to the fact that moment.js doesn't recognize the flatpickr date formats.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@xinyis991105 xinyis991105 requested a review from fanpu September 12, 2021 14:37
@fanpu
Copy link
Contributor

fanpu commented Sep 12, 2021

Checked that scheduler, assessment, course datepickers all work

@xinyis991105 xinyis991105 merged commit 687fbd9 into master Sep 12, 2021
@xinyis991105 xinyis991105 deleted the fix_date_picker branch September 12, 2021 18:17
@magsol
Copy link

magsol commented Sep 13, 2021

How would I merge this into a running Autolab instance? Would I be able to just jump into the running container and delete those 6 lines from the javascript file?

@xinyis991105
Copy link
Contributor Author

Hi Shannon! Please reference our docs for update. If this is not a super urgent fix, we still suggest merging in the latest update, rebuilding the image, and running the new image. Let me know of any other questions.

@magsol
Copy link

magsol commented Sep 16, 2021

Perfect, worked like a charm. Thank you so much!

ugogon pushed a commit to ugogon/Autolab that referenced this pull request Sep 21, 2021
ugogon pushed a commit to ugogon/Autolab that referenced this pull request Oct 13, 2021
ugogon pushed a commit to ugogon/Autolab that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants