Refresh course setting page on error #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanpu
requested changes
Sep 23, 2021
Dockerfile
Outdated
| @@ -54,7 +54,7 @@ RUN mkdir -p /home/app/webapp/log && \ | |||
| USER app | |||
|
|
|||
| # precompile the Rails assets | |||
| RUN RAILS_ENV=production bundle exec rails assets:precompile | |||
| RUN RAILS_ENV=development bundle exec rails assets:precompile | |||
There was a problem hiding this comment.
Could I check why this change is necessary? It will impact the docker-compose installation
There was a problem hiding this comment.
Sorry about that! I was testing my local docker compose! I must've accidentally added this commit. Will remove right away.
fanpu
approved these changes
Sep 23, 2021
ugogon
pushed a commit
to ugogon/Autolab
that referenced
this pull request
Oct 13, 2021
* Local docker config * refresh page after saving on error * revert accidental change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a course setting page to refresh automatically upon receiving erroneous setting information.
Motivation and Context
#1385
How Has This Been Tested?
See the bug report. After following the steps to reproduce, you should now observe the expected behavior.
Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.