-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More detailed roster error messages & sort by account status #1402
Conversation
…e to include line number and email; TODO: update to bulleted list if above certain number of error messages
Just a quick first comment, but why are there such major changes in the CSS files? |
@@ -85,3 +44,18 @@ assignments or download new assignments</font> | |||
<% end %> | |||
|
|||
<% end %> | |||
|
|||
<script src="//cdnjs.cloudflare.com/ajax/libs/jquery-scrollTo/2.1.2/jquery.scrollTo.min.js"></script> | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is because this is still WIP, but it is preferable that scripts be moved to a separate corresponding Javascript file (with similar filename), instead of being included in the html file
looks like my vscode extension autoformatted the file when I saved it |
… being marked as invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested using the test document, and with comma only lines, or lines without enough commas.
There's two other minor issues (that existed prior to this feature) discovered from testing @xinyis991105 :
- If student have already been dropped before, it will still appear as red
- If a student is dropped because it no longer exists on the roster. But then in a new roster it is added back again, the student is not "undropped" <- not sure if that's a good behavior
We should add them to the backlog
Description
Updated the error messages to include more information about roster uploads and CSV parsing; added a "sort by account status" toggle that displays newly-added and newly-dropped accounts at the top of the confirmation screen.
Motivation and Context
This updated roster upload aims to address two main issues:
How Has This Been Tested?
(incomplete)
Types of changes
Checklist:
Other issues / help required
2 remaining rubocop errors:
Not sure if removing the
rescue StandardError
from here will break anything, so I'd like to have someone else look at this as well.