Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated confirm button at top roster upload confirmation screen #1473

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

michellexliu
Copy link
Contributor

Description

Added a second "Confirm" button at the top of the student table on the roster upload confirmation screen.
Screen Shot 2022-02-22 at 11 46 26 PM

Motivation and Context

Suggested by Iliano so that professors don't need to scroll all the way to the bottom of the screen for large classes.

How Has This Been Tested?

Clicked the new button to check that

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@oliverli oliverli requested a review from victorhuangwq March 1, 2022 22:13
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm button appears at the top. LGTM

@michellexliu michellexliu merged commit 5903c05 into master Mar 1, 2022
@michellexliu michellexliu deleted the confirm-at-top branch March 1, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants