Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-expanded Admin Course menu #1509

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

damianhxy
Copy link
Member

As per title, under "Manage Course", have the "Admin Course" dropdown menu pre-expanded.

Description

Add active tag to the corresponding li element.

Motivation and Context

For instructors, the "Admin Course" dropdown menu is the only menu on that page. It is convenient to have it pre-expanded.

How Has This Been Tested?

Dropdown menu is pre-expanded as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@damianhxy damianhxy requested a review from victorhuangwq April 27, 2022 14:51
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested & works as expected.

@damianhxy damianhxy merged commit a6f91d0 into master Apr 27, 2022
@damianhxy damianhxy deleted the expanded-admin-course-menu branch April 27, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants