Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of Admin Course button #1511

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Apr 27, 2022

Description

This PR implements the relevant aria code from the assessment view page to the manage course page. It also replaces the obsolete onkeypress event with onkeydown.

Motivation and Context

Similar to #1215, adding the aria-expanded attribute improves accessibility.

How Has This Been Tested?

Checked that the dropdowns have the correct initial aria-expanded attribute (true for admin course and false for admin autolab). Also checked that clicking on a dropdown, or tabbing to a dropdown and pressing the enter key, toggles the aria-expanded attribute correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@victorhuangwq victorhuangwq requested a review from najclark April 28, 2022 20:19
Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggested changes regarding the drag/drop handin functionality.

app/assets/javascripts/handin.js Outdated Show resolved Hide resolved
app/views/assessments/_submission_panel.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianhxy damianhxy requested a review from xinyis991105 April 29, 2022 03:46
Copy link
Contributor

@xinyis991105 xinyis991105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damianhxy damianhxy merged commit da1689c into master Apr 29, 2022
@damianhxy damianhxy deleted the admin-course-menu-aria branch April 29, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants