Improve accessibility of Admin Course button #1511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the relevant aria code from the assessment view page to the manage course page. It also replaces the obsolete
onkeypress
event withonkeydown
.Motivation and Context
Similar to #1215, adding the
aria-expanded
attribute improves accessibility.How Has This Been Tested?
Checked that the dropdowns have the correct initial
aria-expanded
attribute (true
for admin course andfalse
for admin autolab). Also checked that clicking on a dropdown, or tabbing to a dropdown and pressing the enter key, toggles thearia-expanded
attribute correctly.Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.