-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better config reload error handling #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Note that certain classes of errors (such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This reverts commit c7567d0.
…ndling Revert "Better config reload error handling (autolab#1522)"
Modify course and assessment config reload code to better handle cases where an invalid config is provided
Description
reload.html
to be consistent with assignmentreload.html
Motivation and Context
Currently, course config reload does not set the
@error
variable, so the error page is not correctly rendered.Furthermore, config reload does not check the syntax of the config file before saving it, meaning that it's possible to reload a file with invalid syntax and corrupt the config.
Also fixes #1516
How Has This Been Tested?
courses/<course-name>/course.rb
and reload config. Error should be correctly caught and config incourseConfig/<course-name>.rb
unaffectedcourses/<course-name>/<assessment-name>/<assessment-name>.rb
and reload config. Error should be correctly caught and config inassessmentConfig/<course-name>-<assessment-name>.rb
unaffectedTypes of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting