Fix user dropdown on assessments view #1547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initializing user dropdown, use vanilla js
M.Dropdown.init(elems, options)
over jQuery.dropdown()
.Motivation and Context
Currently, on the assessment view page,
git_submission.js
andhandin.js
have the linerequire semantic-ui
, which imports all semantic-ui javascript, particularlysemantic-ui/dropdown
. However, this overrides the original materialize dropdown method, causing the user dropdown to not work. The same problem occurs on the metrics watchlist page.To remedy this and future proof the code, switch to the vanilla js method of initializing the dropdown.
How Has This Been Tested?
On assessment view page (and a variety of other pages), user dropdown works as intended.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting