Disable user data fields during CUD edit #1562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
:email
,:first_name
and:last_name
fields on edit CUD page, but enable on new CUD pageMotivation and Context
In #877, a hotfix was applied to address a bug which prevented users from adding students to a course. However, the modified partial is also used by the edit CUD page. This means that when editing CUDs, the
email
,first name
, andlast name
of students can be changed. As commented by @cg2v, it doesn't make sense for the fields to be edited here (first name
andlast name
can be edited via manage users,email
shouldn't be edited at all).This PR adds a local parameter when calling the
fields
partial to determine whether the above mentioned fields should be disabled.How Has This Been Tested?
email
,first name
andlast name
fields should be editableemail
,first name
andlast name
fields should not be editableTypes of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting