Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim prerenders #1574

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Trim prerenders #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c9207
Remove version links prerender
damianhxy Jul 28, 2022
cfcff09
Remove prev student prerender
damianhxy Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/views/submissions/_version_links.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,13 @@
<%= link_to(url_for([:view, @course, @assessment, @prevVersion[:submission], header_position: @prevVersion[:header_position]]), class: "btn small", title: "Previous version containing this file (shortcut: [)", id: "prev_version_link") do %>
<i class="material-icons">south</i>
<% end %>
<link rel="prerender" href=<%= url_for([:view, @course, @assessment, @prevVersion[:submission], header_position: @prevVersion[:header_position]]) %> />
damianhxy marked this conversation as resolved.
Show resolved Hide resolved
<% else %>
<a class="btn disabled"><i class="material-icons">south</i></a>
<% end %>
<% if !@nextVersion.nil? %>
<%= link_to(url_for([:view, @course, @assessment, @nextVersion[:submission], header_position: @nextVersion[:header_position]]), class: "btn small", title: "Next version containing this file (shortcut: ])", id: "next_version_link") do %>
<i class="material-icons">north</i>
<% end %>
<link rel="prerender" href=<%= url_for([:view, @course, @assessment, @nextVersion[:submission], header_position: @nextVersion[:header_position]]) %> />
<% else %>
<a class="btn disabled"><i class="material-icons">north</i></a>
<% end %>
Expand Down
1 change: 0 additions & 1 deletion app/views/submissions/view.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
<%= link_to(url_for([:view, @course, @assessment, @prevSubmission]), class: "valign-wrapper", title: "Previous student (shortcut: ←)", id: "prev_submission_link") do %>
<i class="material-icons" style="margin-right: 3px">arrow_back</i> <%= @prevSubmission.course_user_datum.user.email %>
<% end %>
<link rel="prerender" href= <%= url_for([:view, @course, @assessment, @prevSubmission])%> />
<% end %>
</div>
<div class="col s8 center-align valign-wrapper submission-controls">
Expand Down