Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of source in submission row #1577

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

20wildmanj
Copy link
Contributor

Previously, the upload source name in a student's submissions row for an assessment wasn't vertically aligned with the rest of the row. Just added some styling to make it centered.

Before:

Screen Shot 2022-08-05 at 16 03 00

After:

Screen Shot 2022-08-05 at 16 03 05

How Has This Been Tested?

  • Go to an assessment, make a submission / view submissions, and see that the submission source is vertically aligned.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@20wildmanj 20wildmanj self-assigned this Aug 5, 2022
@20wildmanj 20wildmanj requested review from michellexliu and removed request for michellexliu August 5, 2022 23:14
@20wildmanj 20wildmanj changed the title Fix alignment of source in submission row Draft:Fix alignment of source in submission row Aug 6, 2022
@20wildmanj 20wildmanj marked this pull request as draft August 6, 2022 06:30
@20wildmanj 20wildmanj changed the title Draft:Fix alignment of source in submission row Fix alignment of source in submission row Aug 7, 2022
@20wildmanj 20wildmanj marked this pull request as ready for review August 7, 2022 17:34
@20wildmanj 20wildmanj requested a review from damianhxy August 7, 2022 17:34
Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed vertical alignment

lgtm!

@20wildmanj 20wildmanj merged commit 05bcebc into master Aug 7, 2022
@20wildmanj 20wildmanj deleted the joeywildman-fixsubmissionrowalign branch August 7, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants