-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update Extension functionality #1592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellexliu
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds update functionality to extensions, alongside several improvements
minDate
after any changes (due to re-initialization of component)To update extensions, instructors can either click on a student's email in the sidebar, or input the student's name/email as usual. Then,
Motivation and Context
Currently, the only way to update an extension is to delete and re-create it, which can be error-prone. This PR adds the functionality to directly update an extension.
How Has This Been Tested?
No extensions screen
![Screen Shot 2022-09-17 at 23 38 40](https://user-images.githubusercontent.com/9074856/190884644-cb5ab289-5025-44dc-b5b1-2e7f140ea507.png)
Deletion confirmation
![Screen Shot 2022-09-17 at 23 39 08](https://user-images.githubusercontent.com/9074856/190884651-6c12b1f8-eb21-46c9-a2a8-a5852e388312.png)
Clicking on email / inputting name automatically populates fields and displays warning
![Screen Shot 2022-09-17 at 23 39 23](https://user-images.githubusercontent.com/9074856/190884666-2aa5a1b1-82c1-4a1a-b807-9c91a8515109.png)
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting