Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of handin history page #1602

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Sep 24, 2022

Description

Remove unnecessary italics, introduce line breaks, improve handling of infinite extensions and add pluralization.

Motivation and Context

As per description.

How Has This Been Tested?

Before
2 days extension
Screen Shot 2022-09-24 at 14 39 58
Infinite extension
Screen Shot 2022-09-24 at 14 39 23

After
2 days extension
Screen Shot 2022-09-24 at 14 45 31
Infinite extension
Screen Shot 2022-09-24 at 14 45 45

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@victorhuangwq
Copy link
Contributor

You seemed to have swap the screenshot for the After section

@damianhxy
Copy link
Member Author

You seemed to have swap the screenshot for the After section

Fixed!

@victorhuangwq
Copy link
Contributor

Could you help do a quick check on this PR #1609 and let me know if there's any conflicts? If there isn't I will do a quick review

Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge if there's no conflict with #1609

@damianhxy
Copy link
Member Author

Could you help do a quick check on this PR #1609 and let me know if there's any conflicts? If there isn't I will do a quick review

Yup, no conflicts!

@damianhxy damianhxy merged commit 3e26da8 into master Sep 24, 2022
@damianhxy damianhxy deleted the handin-history-helptext branch September 24, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants