Make attachment upload more understandable, indicate if attachment unreleased #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the italics for |
damianhxy
reviewed
Sep 25, 2022
| <%= f.text_field :mime_type, | ||
| help_text: "Note: If you change the Mime type of a file, you might need to clear your browser's cache in order for you to see the change." %> | ||
| <% end %> | ||
| <ul> |
There was a problem hiding this comment.
Is the purpose of <ul> to make the lines the same length?
damianhxy
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, attachment upload was very confusing, with the buttons not being helpful / informative. Also, if an attachment was unreleased, the instructor wouldn't know unless they went into the edit page for the attachment. I tried to make the upload form give more informative information for each field, and added a (Not Released) to any attachments not released when looking at the assessment page.
Before:
(Earfs is unreleased, but you would never know...)
After:
Still kinda ugly, could polish if that is desired:
New attachment:
Edit attachment: