-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bulk import users from emails #1640
Conversation
@@ -229,6 +229,63 @@ def users | |||
end | |||
end | |||
|
|||
action_auth_level :add_users_from_emails, :instructor | |||
def add_users_from_emails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michellexliu Since you worked with roster upload, before I continue further, could you take a quick look at the logic below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works as expected, but left some comments.
As an additional nit, I realized that I can't press arrow up / down in the text area -- not sure if that was intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments
Other than a comment about error message consistency, LGTM!
Tested with: |
453cc90
to
30c8d78
Compare
@damianhxy do a last check review on the cases above. Thanks! |
Tested cases as working. However, it's a bit weird that we're ignoring middle names altogether. Should we lump it with first names? |
Currently the roster upload doesn't support middle name as well. So I think it's logical to just drop the middle name to be consistent. |
Description
Adds ability to create users from bulk using just email.
Adds:
Motivation and Context
Creating accounts individually for adding CAs and Instructors is tedious for class with of them (~40).
How Has This Been Tested?
Tested Valid Inputs:
Tested Invalid Inputs:
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.