Update the error message for failed partial feedback & refactor getPartialFeedback logic #1671
Conversation
|
Tested
|
|
A less scary message when partial feedback is blank |
|
Maybe we should reword it to There was an error getting your feedback while autograding . Check back once autograding is complete. Basically we should be conveying that it's only the partial feedback not working, not the whole autograding.
|
| function refreshPartial(clicked) { | ||
| const lastPartialFeedback = localStorage.getItem(<%= @job_id %>); |
There was a problem hiding this comment.
job_id does not uniquely identify a job - this counter resets whenever Tango server resets.
You probably need the submission number (and maybe the user).
There was a problem hiding this comment.
At the same time, I believe it isn't as appropriate to use localStorage for storing the feedback as the they do not expire (and won't be deleted automatically) So a students localstorage will get bloated after many submissions to autolab.
Either somehow set an expiry, or explore sessionStorage
https://www.digitalocean.com/community/tutorials/js-introduction-localstorage-sessionstorage
There was a problem hiding this comment.
job_id only uniquely identifies on the Tango side - basically there will not be two jobs running that has the same job_id. So you won't get a situation where you get someone else's partial feedback
…age key to include submission info
…into new-error-message
| submission: <%= @submission_id %>, | ||
| job: <%= @job_id %>, | ||
| user: <%= @cud&.user_id %>, | ||
| } |
There was a problem hiding this comment.
This seems like a good key - issue resolved while testing
| function refreshPartial(clicked) { | ||
| const lastPartialFeedback = sessionStorage.getItem(sessionKey); |
There was a problem hiding this comment.
SessionStorage use here resolved the issue of persistence previously.
| $('.feedback-status').html("In-Progress"); | ||
| $('.feedback-status').removeClass("feedback-status__queued"); | ||
| $('.feedback-status').addClass("feedback-status__inprogress"); | ||
| $( "#result-body" ).load(window.location.href + " #result-body" ); |
There was a problem hiding this comment.
May I ask what's going on in this line of code? I don't quite get what this line does.
There was a problem hiding this comment.
Updates the badge and the loading message in the right-hand panel to the in-progress states when going from queued to in-progress
Description
tango_get_partial_feedbackto prevent possible error that occurs when attempting to access partial feedback for job that is being taken off the queue.How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting