-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved "Install Assessment" button to top box, removed "Instructor Actions" header, renamed Assignments header to Assessments #1683
Conversation
Could we get an icon for the install assessment button to match the aesthetic of the other buttons? You can find the list of icons here: https://materializecss.com/icons.html For example,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would like to see an icon for the install assessments button, though
Icon looks good |
Would prefer to revert the button name to "Install Assessment" (singular), and also restore the trailing newline |
Added newline and changed assessments to assessment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice job!
LGTM |
Description
Motivation and Context
Small UI fix because instructor actions is unnecessary as its own component and assessments is also unnecessary as a header if it is empty.
How Has This Been Tested?
Previous:
After:
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting