Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved "Install Assessment" button to top box, removed "Instructor Actions" header, renamed Assignments header to Assessments #1683

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

KesterTan
Copy link
Contributor

@KesterTan KesterTan commented Jan 10, 2023

Description

  • Moved "Install Assessment" button to top box
  • Removed "Instructor Actions" header
  • Renames Assignments header to Assessments
  • Assessments header will only be shown if there are assessments
  • Added icon to assignments

Motivation and Context

Small UI fix because instructor actions is unnecessary as its own component and assessments is also unnecessary as a header if it is empty.

How Has This Been Tested?

  1. Tested mobile responsiveness.
  2. Tested the buttons and other buttons.

Previous:

image

After:

Screenshot 2023-01-12 at 12 57 55 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@KesterTan KesterTan marked this pull request as ready for review January 10, 2023 15:37
@najclark najclark self-requested a review January 10, 2023 21:41
@damianhxy
Copy link
Member

damianhxy commented Jan 11, 2023

Could we get an icon for the install assessment button to match the aesthetic of the other buttons?

You can find the list of icons here: https://materializecss.com/icons.html

For example,

Screenshot 2023-01-11 at 11 29 40

<%= link_to "<i class='material-icons left'>input</i>Install Assessment".html_safe, ...

Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would like to see an icon for the install assessments button, though

@damianhxy
Copy link
Member

Icon looks good

@damianhxy
Copy link
Member

Would prefer to revert the button name to "Install Assessment" (singular), and also restore the trailing newline

@KesterTan
Copy link
Contributor Author

Added newline and changed assessments to assessment

Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice job!

@damianhxy
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants