-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deadline warning for non-submittable assignments #1701
Removed deadline warning for non-submittable assignments #1701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michellexliu Functionally, this works. We might want to touch up on the wording / styling before merging though.
@michellexliu Thanks for the feedback. I will definitely try to improve them as much as possible. I would also like to have your suggestions over it. Please let me know. |
Thanks @damianhxy for the suggestions. I will commit the changes in some time. |
Hi, Please review the PR now after wording and styling changes. Thanks! |
I changed the reviewer by mistake. Sorry for that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushalnl7 I took a closer look and left some further comments, but otherwise lgtm :)
Hey @damianhxy, thanks for these comments. I have resolved them. |
Looks good to me! |
Thanks @damianhxy @michellexliu. I learnt a lot from this code. I would definitely love to contribute more to this repo. Since I am just a beginner as an open source contributor, I would like to have some suggestions from your side! |
I would suggest #1695 next as it should be a fairly simple change (scoping styles appropriately). Let me know what you think! |
Yes, looks great. Will go for this next. Thanks! |
Removed deadline warning for non-submittable assignments
Description
Any submission would have a due datetime as well as a late datetime to submit the assignment. These datetimes are displayed on the submission page. The user also have a option to disable the submissions. Previously, these datetimes were displayed even when the submissions are closed. I changed this such that if the submission is disabled, then instead of the datetime, it shows the attention message to the user that the submission is closed.
Before change -
After change -
Motivation and Context
The change is in regards to the issue mentioned in #1696.
How Has This Been Tested?
As can be seen in the description section, the screenshots are attached about how a change in submission acceptance can change the output message on the submission page.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting