Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer on course view page #1739

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix footer on course view page #1739

merged 1 commit into from
Jan 31, 2023

Conversation

damianhxy
Copy link
Member

Description

  • Remove extraneous div tag

Motivation and Context

In #1143, an extra </div> tag was introduced, causing the footer to display incorrectly.

How Has This Been Tested?

Before
Screenshot 2023-01-30 at 14 08 13

After
Screenshot 2023-01-30 at 14 08 20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

Copy link
Member

@evanyeyeye evanyeyeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful (changed my life). LGTM.

Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianhxy damianhxy merged commit a864e75 into master Jan 31, 2023
@damianhxy damianhxy deleted the fix-course-footer branch January 31, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants