-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed "Manage Autolab" button from a page redirect to a dropdown #1758
Conversation
Can you update your PR so that it removes any RSpec tests for |
You should fully remove any code related to the admin#show method. In In action_auth_level :show, :administrator
def show; end |
Currently, clicking on the dropdown simply triggers it open again, rather than closes it. Is there a way to change this behavior? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving some comments, but some were unaddressed and some new issues were introduced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Left a nit about spacing
- Iffy dropdown behavior persists, but it is not a big deal and can be resolved in a future PR if necessary (also, only happens when I enable touch simulation on firefox, not sure if it actually affects mobile)
lgtm
Description
Screenshot of the new dropdown list on desktop
Screenshot of the new dropdown list on mobile
Motivation and Context
Originally, clicking the button redirects the user to this page with five links.
There's no value in having those links in a separate page since they are only five links. Hence, the dropdown.
How Has This Been Tested?
Enter developer login below the login page.
![Screenshot 2023-02-02 at 11 46 29 AM](https://user-images.githubusercontent.com/65066221/216387938-b0b52094-c6f8-465a-9791-01a58c2786fa.png)
Click the Manage Autolab button on the top right hand corner
![Screenshot 2023-02-02 at 11 46 56 AM](https://user-images.githubusercontent.com/65066221/216388036-23851c9a-693d-4a2b-a11c-11b2510adb46.png)
Change the browser width to view the change in the mobile sidebar as well.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting