Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long lines in annotations #1780

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Wrap long lines in annotations #1780

merged 2 commits into from
Feb 5, 2023

Conversation

damianhxy
Copy link
Member

Description

  • Add word-break: break-word; to annotation descriptions

Motivation and Context

Currently, long lines in annotations do not wrap, and causes an overflow.

Fixes #1772

How Has This Been Tested?

Before
Screenshot 2023-02-05 at 14 38 19

After
Screenshot 2023-02-05 at 14 38 23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified long words get wrapped, lgtm

@damianhxy damianhxy merged commit a00af43 into master Feb 5, 2023
@damianhxy damianhxy deleted the annotation-word-break branch February 5, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No word breaks in global annotations
2 participants