-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix directory permissions for assessment imports #1906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d5e057
to
4261bc1
Compare
4261bc1
to
d72dd6b
Compare
damianhxy
approved these changes
May 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM by @20wildmanj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses failing unit tests in
assessments_controller_spec.rb
forimportAsmtFromTar
by correctly setting directory permissions.Motivation and Context
Tests were failing due to
Archive.in_dir?
check being strict, meaning that we skipped over the assessment directory itselfentry.header.mode
is passed tomkdir_p
, which is in general incorrect. This is because modes might be specified with the file type, e.g.100644
indicates a file with permissions0644
. See https://unix.stackexchange.com/a/450488 for more details.This resulted in directories with bad permissions if we process a file and
To remedy this, the PR
0755
for the creation of parent directories when processing a filein_dir?
check to allow for equalityHow Has This Been Tested?
Run
bundle exec rails spec
See that importing assessments still work manually:
homework02-correct.tar.zip
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting