Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock passenger-ruby27 to v2.5.0 #1929

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Lock passenger-ruby27 to v2.5.0 #1929

merged 1 commit into from
Jun 21, 2023

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Jun 21, 2023

Summary

Summary generated by Reviewpad on 21 Jun 23 19:02 UTC

This pull request locks passenger-ruby27 to v2.5.0 in the Dockerfile.

Description

Lock the version of passenger-ruby27 in the Dockerfile to v2.5.0.

(Essentially UB-CSE-IT@1730a50)

Motivation and Context

With passenger-docker v2.5.1 (changelog), the version of ruby 2.7.x used was bumped to 2.7.8.

This is at odds with the Gemfile, preventing the image from building.

How Has This Been Tested?

Run docker compose build before and after checking out this PR in the Autolab submodule of autolab-docker.

BEFORE
Screenshot 2023-06-22 at 02 54 19

AFTER
Screenshot 2023-06-22 at 02 58 56

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@damianhxy damianhxy requested a review from 20wildmanj June 21, 2023 19:02
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 21, 2023
@damianhxy damianhxy added this pull request to the merge queue Jun 21, 2023
Merged via the queue into master with commit cace108 Jun 21, 2023
@damianhxy damianhxy deleted the lock-dockerfile-version branch June 21, 2023 19:41
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants