Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint views/schedulers, views/metrics, views/lti_nrps, views/lti_config, views/extensions #1977

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

20wildmanj
Copy link
Contributor

@20wildmanj 20wildmanj commented Sep 10, 2023

Summary

Summary generated by Reviewpad on 18 Sep 23 15:30 UTC

This pull request includes the following changes:

  • In the file app/views/lti_config/index.html.erb, the changes handle the case when @lti_config_hash is nil and improve code readability and consistency.
  • In the file app/views/metrics/index.html.erb, there are multiple changes including modifying variable values, adding autocomplete attributes, and formatting changes.
  • In the file sync_roster.html.erb, a space has been added before the closing curly brace in the locals hash.
  • In the file index.html.erb, changes include updating a method, modifying indentation, and improving code readability.
  • In the file edit.html.erb, the changes include indentation, adding a builder option, and adding help text and placeholders for form fields.
  • In the file index.html.erb in the app/views/extensions directory, there are changes to the script tag, table rows, table cells, and link to delete an extension.
  • In the file new.html.erb in the app/views/schedulers directory, changes include updating help text attributes, adding default values, and including a checkbox attribute.

These changes aim to improve code readability, handle edge cases, and provide more informative help text.

Description

  • lint views/schedulers, views/metrics, views/lti_nrps, views/lti_config, views/extensions using erblint using bundle exec erblint app/views/*(folder)/*(file).html.erb -a

Motivation and Context

  • Part of summer linting

How Has This Been Tested?

  • go to each individual page, ensure that it renders properly

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

@reviewpad reviewpad bot requested a review from michellexliu September 10, 2023 16:59
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Sep 10, 2023
app/views/extensions/index.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@michellexliu michellexliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@20wildmanj 20wildmanj added this pull request to the merge queue Sep 18, 2023
Merged via the queue into master with commit 14bc1f4 Sep 18, 2023
@20wildmanj 20wildmanj deleted the joeywildman-lint-views-schedulers branch September 18, 2023 15:36
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 5, 2024
…g, views/extensions (autolab#1977)

* lint views/schedulers, views/metrics, views/lti_nrps, views/lti_config, views/extensions

* fixed student selection

(cherry picked from commit 14bc1f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants