lint views/schedulers, views/metrics, views/lti_nrps, views/lti_config, views/extensions #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary generated by Reviewpad on 18 Sep 23 15:30 UTC
This pull request includes the following changes:
app/views/lti_config/index.html.erb
, the changes handle the case when@lti_config_hash
isnil
and improve code readability and consistency.app/views/metrics/index.html.erb
, there are multiple changes including modifying variable values, adding autocomplete attributes, and formatting changes.sync_roster.html.erb
, a space has been added before the closing curly brace in thelocals
hash.index.html.erb
, changes include updating a method, modifying indentation, and improving code readability.edit.html.erb
, the changes include indentation, adding a builder option, and adding help text and placeholders for form fields.index.html.erb
in theapp/views/extensions
directory, there are changes to the script tag, table rows, table cells, and link to delete an extension.new.html.erb
in theapp/views/schedulers
directory, changes include updating help text attributes, adding default values, and including a checkbox attribute.These changes aim to improve code readability, handle edge cases, and provide more informative help text.
Description
views/schedulers
,views/metrics
,views/lti_nrps
,views/lti_config
,views/extensions
usingerblint
usingbundle exec erblint app/views/*(folder)/*(file).html.erb -a
Motivation and Context
How Has This Been Tested?
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting