-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add course access codes, fix breadcrumbs #2065
Conversation
The reason why it doesn't turn red on Act As User is because of the autocomplete method
Warning Rate Limit Exceeded@damianhxy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 12 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates focus on enhancing the user experience and system functionality across various controllers and views, with significant emphasis on breadcrumb consistency, self-enrollment via access codes, and UI improvements. Changes include the addition of breadcrumb management methods, the introduction of self-enrollment features for courses, updates to breadcrumb handling in multiple controllers, and adjustments to form handling and page titles. These modifications aim to streamline navigation, improve enrollment processes, and ensure a more intuitive interface for users. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Note: need to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside nits
* Fix titles * Fix more titles * Add join_course, move contact to Home controller * Update documentation * Properly configure analytics for development * Remove TODO The reason why it doesn't turn red on Act As User is because of the autocomplete method * Don't regenerate if access code already exists * Don't persist drop flash * Add pattern to join course form * Remove unnecessary defaults * More missing titles * Don't persist Tango error flash * Fixup breadcrumbs * More breadcrumbs fixes * Revamp developer login page * Make titles smaller * Address nits * Use nil to represent no access code * Fix tests * Simplify logic * Exract set_edit_assessment_breadcrumb * Update uniqueness condition to allow_nil * More fixes to breadcrumbs, update test * Decrease header sizes further * Move join_course to courses controller * Remove test * Add basic tests * Fix nits re: developer_login * Guard breadcrumb methods * Standardize naming of "View Gradehseet" and "View Submission" * Guard breadcrumb helpers * Guard breadcrumb helpers * Standardize naming of add user to course page * Add direct join link * Add additional tests * Extract nickname check * Proper mutual exclusion for instructor - ca - dropped * Add copy to clipboard button * Correctly use content_for tags on export course page * Bump cdn libraries (jquery-ui, semantic-ui), use jquery-migrate * Fix breadcrumb for export course * Fix breadcrumb for export course, reindent code * Simplify mutual exclusion code, add backend check * Use constants for regex, upcase strings * Add manage course breadcrumb for docker controller * Extract breadcrumb for device_flow_activation_controller * Extract breadcrumb for course_user_data_controller.rb * Remove redundant to_s (cherry picked from commit eccc6a9)
Description
Motivation and Context
At the start of the semester, there is a lot of churn in the user roster and (barring LTI integration) instructors do not wish to keep uploading new rosters. This PR enables instructors to generate and distribute an access code that students can use to join a course on their own.
Once the user roster is stable, instructors can disable the access code and upload the final roster to drop any unwanted students.
Access codes are disabled by default, and are generated when enabled. If an instructor wishes to regenerate the access code, they can disable then enable it.
Also adds missing breadcrumbs where applicable.
Close #865
Closes #1786
How Has This Been Tested?
Access code can be enabled via Course Settings
Access Code
Clicking the "copy" button copies the access code
Clicking the "link" button copies the direct join link
Access Code disabled
Join course page
Accessible via user dropdown
![Screenshot 2024-02-03 at 15 15 28](https://private-user-images.githubusercontent.com/9074856/302060600-042d331c-599f-4dad-a726-9bf027784e91.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTk2MDAsIm5iZiI6MTczOTM1OTMwMCwicGF0aCI6Ii85MDc0ODU2LzMwMjA2MDYwMC0wNDJkMzMxYy01OTlmLTRkYWQtYTcyNi05YmYwMjc3ODRlOTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTEyMTQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTJkZGQ3MDdhNWY5YTgyMzZlNmJhMmQxMjliNTE0YjYwYzRhNTIxMjk2MDM1YTkxM2IwYWFiMGM3NjA1YTgyOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.CYcHKrM0Le0W3GBDmZdDFMHA6GRGd31MkV5kgYjP5LE)
Things to test for access code
Other things to test
mkdocs serve
)Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting