-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual cues improvements #2108
Visual cues improvements #2108
Conversation
WalkthroughWalkthroughThe recent update enhances the user interface and experience related to assessments, focusing on display settings and date visibility. A key feature is the introduction of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
db/migrate/20240226083719_add_hover_assessment_date_to_users.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hover toggle works, but otherwise style-wise hover needs refinements. Clearfix is still jank so needs some more work, and also code organization could be approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides nit
* add visual cue to course index page * Implement toggle for hover * remove bold from course index * fix clearfix * get rid of console output * fix schema * fix schema * fix schema * add content for tag * Address comments and fix clearfix * Move date to partial * Change line endings * fix schema * Remove dead code (cherry picked from commit 3ef1dcd)
Description
hover_assessment_date
for users)Motivation and Context
Addresses #2031
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting