-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description under name in assessments/edit to reflect new naming rules #2183
Conversation
WalkthroughWalkthroughThe changes involve updating the help text for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Form
participant Documentation
User->>Form: Access assessment form
Form->>User: Display name field with help text
User->>Form: Enter name
Form->>User: Validate name
alt Invalid name
Form->>User: Show error
else Valid name
Form->>Documentation: Link to naming rules
end
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Description
#1987 greatly expanded the possible range of assessment names from lowercase alphanumeric characters. However, the description in
assessments/edit
still referred to the old naming rules. This change simply updates the description to properly reflect the new rulesMotivation and Context
How Has This Been Tested?
Before:
![Screenshot 2024-08-23 at 4 42 06 PM](https://private-user-images.githubusercontent.com/25730111/361061079-8eb3596f-6a76-4764-b731-52497d6d1e4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTgzMTcsIm5iZiI6MTczOTM1ODAxNywicGF0aCI6Ii8yNTczMDExMS8zNjEwNjEwNzktOGViMzU5NmYtNmE3Ni00NzY0LWI3MzEtNTI0OTdkNmQxZTRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMDAxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2ZTY3N2U2MWJlMzI4MThlZGUzNmYxODJhMGMyNjgxZmI1YjE3OGFmY2Q5MWI2NGVhNmY1NmEwZWNmN2Y2YjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Ip0OCnf-1NAWTZw_VXc9wtbiQsbUCYHrCu2P12E_Vh8)
After:
![Screenshot 2024-08-23 at 4 41 46 PM](https://private-user-images.githubusercontent.com/25730111/361061112-8904c5c1-e6d2-4da6-9d3d-97e5c0e7f5b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTgzMTcsIm5iZiI6MTczOTM1ODAxNywicGF0aCI6Ii8yNTczMDExMS8zNjEwNjExMTItODkwNGM1YzEtZTZkMi00ZGE2LTlkM2QtOTdlNWMwZTdmNWIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMDAxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjNzU4MTA0N2QxN2I5NTExMjRjYzdkOTE2MDQ1YjlmODFhOGY5ZjFhMjM1NTNiZDM2ZDg5MjE5OGE3YzFhZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EzHBGhpvhqp9Qyq9iN6ZD_WuGSMNx2NfUGHc_Y7TUDs)
Types of changes