Distributed docker #69
Conversation
|
|
| import config | ||
| from tangoObjects import TangoMachine | ||
|
|
||
| def timeout(command, time_out=1): |
There was a problem hiding this comment.
So I didn't catch this for the last PR, but is there a reason why the timeout function is not in a library somewhere? It looks like timeout and timeoutWithReturnStatus are just copied between all the vmms's.
There was a problem hiding this comment.
Yeah there's no reason. Just hadn't gotten down to separating them.
There was a problem hiding this comment.
Yeah I also commented about this previously. We can have a vmmsUtils or something like that.
|
|
| """ | ||
| try: | ||
| self.log = logging.getLogger("DistDocker") | ||
| self.hosts = ['54.186.238.205', '54.68.89.235'] |
There was a problem hiding this comment.
I'm sure you know this, but this will want to be factored out into a config parameter eventually.
There was a problem hiding this comment.
Yeah. I wanted to think a little more about that. It would be cool to add and remove host machines live instead of having to restart Tango every time. And to do that, maybe we store the path to a separate hosts_config file in the main config file and install a signal handler in DistDocker to reload that config file. But then there're two config files, which is messy and confusing...
There was a problem hiding this comment.
Maybe have a default list in the config file and let the users add new ones through the cmd line client? (Like I think we do for VMs right now)
|
Btw, I think we should switch to the same version control mechanism on Tango. (ie. Having the |
|
Is there any way to disable Travis since it doesn't work Docker? All the red crosses don't mean anything... |
|
|
|
I think there's no way to disable an already existing PR, but since I already disabled it on Travis, new commits/PRs will not go through Travis. |
|
|
|
Looks like new commits are still going through. Don't know about PRs. |
|
Oh and @icanberk I agree with the develop branch idea. How can we do it? |
|
|
|
I would say the first step is to establish a stable version. Once you are there, simply branch out |
|
|
|
|
No description provided.