Fix Linux platform (specifically getBinary(), exec(), and spawn()) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stat utility function returns null (instead of throwing an error) when a path is not found, so handle that case.
|
@facekapow I found a further bug in the Linux support, which only shows up if you don't have |
|
@malept Nice find, thanks! I've merged it in. |
|
tnx, i'll fix it very soon |
|
Now code is being refactored and i will add you fix in new code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the
SudoerLinux.getBinary()function which replaced the path with an object, causing[object Object]to appear as the binary path.There was another bug in
SudoerLinux.exec()andSudoerLinux.spawn()which prevented theDISPLAYvariable from being set correctly ifoptions.envisn't provided.A (good) side effect of the fix for the
exec/spawnbug is that both functions now useenvjust like the native Node.js equivalents (Node passes your currentprocess.envif you don't specify theenvoption).Tested and working on my machine. 👍