Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pipeline options in fit_pipeline #466

Merged
merged 3 commits into from
Aug 12, 2022
Merged

[FIX] pipeline options in fit_pipeline #466

merged 3 commits into from
Aug 12, 2022

Conversation

ravinkohli
Copy link
Contributor

@ravinkohli ravinkohli commented Aug 8, 2022 •
edited
Loading

Fixes #463

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Note that a Pull Request should only contain one of refactoring, new features or documentation changes.
Please separate these changes and send us individual PRs for each.
For more information on how to create a good pull request, please refer to The anatomy of a perfect pull request.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

One line bug fix as dict.update() returns None

Motivation and Context

Fixes #463

How has this been tested?

I have added a test which ensures that users can pass pipeline options to fit_pipeline.

@ravinkohli ravinkohli changed the title Fix pipeline options [FIX] pipeline options in fit_pipeline Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022 •
edited
Loading

Codecov Report

Merging #466 (08bddb6) into development (c7220f7) will increase coverage by 20.97%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           development     #466       +/-   ##
================================================
+ Coverage        64.65%   85.63%   +20.97%     
================================================
  Files              231      231               
  Lines            16304    16314       +10     
  Branches          3009     3012        +3     
================================================
+ Hits             10542    13971     +3429     
+ Misses            4714     1506     -3208     
+ Partials          1048      837      -211
Impacted Files Coverage Δ
autoPyTorch/api/base_task.py 83.81% <100.00%> (+2.87%) ⬆️
autoPyTorch/constants.py 100.00% <0.00%> (ø)
...bone/forecasting_encoder/seq_encoder/TCNEncoder.py 96.46% <0.00%> (+1.76%) ⬆️
autoPyTorch/ensemble/ensemble_selection.py 96.87% <0.00%> (+2.08%) ⬆️
...nts/setup/network_backbone/ShapedResNetBackbone.py 100.00% <0.00%> (+2.08%) ⬆️
autoPyTorch/evaluation/utils.py 73.61% <0.00%> (+2.77%) ⬆️
...peline/components/training/trainer/MixUpTrainer.py 97.14% <0.00%> (+2.85%) ⬆️
...ar_preprocessing/feature_preprocessing/Nystroem.py 91.17% <0.00%> (+2.94%) ⬆️
...casting_backbone/forecasting_decoder/RNNDecoder.py 91.66% <0.00%> (+3.33%) ⬆️
... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ravinkohli ravinkohli linked an issue Aug 9, 2022 that may be closed by this pull request
[AssertionError in fit_pipeline() when pipeline_options is not None #463
Closed
3 tasks
theodorju
theodorju reviewed Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@theodorju theodorju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change fixes the issue and the test ensures correct functionality. I'm leaving a minor comment on the test case parametrization.

test/test_api/test_api.py Outdated Show resolved Hide resolved
@ravinkohli ravinkohli merged commit 6d17012 into automl:development Aug 12, 2022
github-actions bot pushed a commit that referenced this pull request Aug 12, 2022
Ravin Kohli: [FIX] pipeline options in fit_pipeline (#466)
031db24
@ravinkohli ravinkohli mentioned this pull request Aug 23, 2022
Merged
10 tasks
ravinkohli added a commit that referenced this pull request Aug 23, 2022
@ravinkohli @dengdifan
[RELEASE] v0.2.1 (#475)
56a2ac1 
* [FIX] Documentation and docker workflow file (#449)

* fixes to documentation and docker

* fix to docker

* Apply suggestions from code review

* add change log for release (#450)

* [FIX] release docs (#452)

* Release 0.2

* Release 0.2.0

* fix docs new line

* [FIX] ADD forecasting init design to pip data files (#459)

* add forecasting_init.json to data files under setup

* avoid undefined reference in scale_value

* checks for time series dataset split (#464)

* checks for time series dataset split

* maint

* Update autoPyTorch/datasets/time_series_dataset.py

Co-authored-by: Ravin Kohli <13005107+ravinkohli@users.noreply.github.com>

Co-authored-by: Ravin Kohli <13005107+ravinkohli@users.noreply.github.com>

* [FIX] Numerical stability scaling for timeseries forecasting tasks (#467)

* resolve rebase conflict

* add checks for scaling factors

* flake8 fix

* resolve conflict

* [FIX] pipeline options in `fit_pipeline` (#466)

* fix update of pipeline config options in fit pipeline

* fix flake and test

* suggestions from review

* [FIX] results management and visualisation with missing test data (#465)

* add flexibility to avoid checking for test scores

* fix flake and test

* fix bug in tests

* suggestions from review

* [ADD] Robustly refit models in final ensemble in parallel (#471)

* add parallel model runner and update running traditional classifiers

* update pipeline config to pipeline options

* working refit function

* fix mypy and flake

* suggestions from review

* fix mypy and flake

* suggestions from review

* finish documentation

* fix tests

* add test for parallel model runner

* fix flake

* fix tests

* fix traditional prediction for refit

* suggestions from review

* add warning for failed processing of results

* remove unnecessary change

* update autopytorch version number

* update autopytorch version number and the example file

* [DOCS] Release notes v0.2.1 (#476)

* Release 0.2.1

* add release docs

* Update docs/releases.rst

Co-authored-by: Difan Deng <33290713+dengdifan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodorju theodorju theodorju approved these changes

@nabenabe0928 nabenabe0928 Awaiting requested review from nabenabe0928

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AssertionError in fit_pipeline() when pipeline_options is not None
2 participants
@ravinkohli @theodorju