Extend configuration space to act as mapping #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
===========================================
+ Coverage 24.11% 66.33% +42.21%
===========================================
Files 17 17
Lines 1613 1613
===========================================
+ Hits 389 1070 +681
+ Misses 1224 543 -681
Continue to review full report at Codecov.
|
mfeurer
reviewed
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
ConfigurationSpaceandConfigurationclasses to implement the Mapping interface . This makes them behave more like dictionaries, extending their functionality to allowconfig.items(), config.values()as well as features such as unpackingmydict = {**config}.This PR also removes an old flake8 package which did not seem to do anything and which has now been replaced with native functionality in flake8.
Lastly, it renames a file that tested an
iracewriter which no longer seems to exist. This was renamed to thatpytestwill skip this file during its running.There are 3 tests added, 2 to test the functionality described for
ConfigurationandConfigurationSpaceand 1 to ensure the order of hyperparemeters for a Config matches those of the ConfigSpace, as advertised in the doc string.