Check new neighbors deterministically #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One-exchange neighborhood iterator rigorously checks some of the generated configurations. The check is performed with the probability 5 %, as decided by `np.random`. Make the check deterministic (using an explicitly seeded `np.random.RandomState`) instead of relying on the default numpy random state, which need not be seeded.
mfeurer
approved these changes
Sep 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 66.33% 66.33%
=======================================
Files 17 17
Lines 1613 1613
=======================================
Hits 1070 1070
Misses 543 543 Continue to review full report at Codecov.
|
mfeurer
requested changes
Sep 16, 2021
of `get_one_exchange_neighborhood`. Update the hard-coded expected values.
I have updated the fixture to match the current behavior of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-exchange neighborhood iterator rigorously checks some of the generated configurations. The check is performed with the probability 5 %, as decided by
np.random.Make the check deterministic (using an explicitly seeded
np.random.RandomState) instead of relying on the default numpy random state, which need not be seeded.Resolves #194.