-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_size() #208
Add get_size() #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 66.33% 68.17% +1.83%
==========================================
Files 17 17
Lines 1613 1681 +68
==========================================
+ Hits 1070 1146 +76
+ Misses 543 535 -8
Continue to review full report at Codecov.
|
Unfortunately, I think this is slightly harder than calculating the product of possible values. To be accurate it would also have to take into account conditionals and forbidden clauses. We can seperate them into two cases:
It's worth pointing out that this complicated procedure is only required if not in case 1 or we realise that case 1 is actually a case 2 problem. Edit: I realized the above only works for forbidden clauses and some more thinking would have to be done for conditionals, for example, consider that the entire region of the config space for a random forest is only active when |
Yes, I agree, these are all not covered. However, I really don't want to enumerate all possible hyperparameter combinations. Maybe this should be called |
I would be okay with the method name change and some documentation on it, just as long as it doesn't give false impressions, I can imagine a research paper incorrectly using it to give the size of their config space. |
What do you think about the improved API description? |
Seems good to me :) Approved |
Fixes #31