-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Binary wheels #224
Merged
Merged
Add: Binary wheels #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 17 17
Lines 1627 1627
=======================================
Hits 1092 1092
Misses 535 535 Continue to review full report at Codecov.
|
mfeurer
reviewed
Jan 27, 2022
mfeurer
reviewed
Jan 31, 2022
mfeurer
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to build as many wheels as possible for windows, macos and linux using
cibuildwheel
to help with issues like #130 and #165.Splits building into two, one for an
sdist
and one for thebdists
's:wheels.yml
- workflow that builds a majority of wheels and test them withcibuildwheel
.sdist.yml
- workflow to build the source distribution and release it, however we only test this with linux. I'm not sure it makes sense to also build source distribution for windows and mac given that there are bwheels which should solve build issues that users face.Have not looked into testing this with conda python, only with the python that
cibuildwheel
will use.