Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Binary wheels #224

Merged
merged 24 commits into from
Feb 1, 2022
Merged

Add: Binary wheels #224

merged 24 commits into from
Feb 1, 2022

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Jan 26, 2022

Attempts to build as many wheels as possible for windows, macos and linux using cibuildwheel to help with issues like #130 and #165.

Splits building into two, one for an sdist and one for the bdists's:

  • wheels.yml - workflow that builds a majority of wheels and test them with cibuildwheel.
  • sdist.yml - workflow to build the source distribution and release it, however we only test this with linux. I'm not sure it makes sense to also build source distribution for windows and mac given that there are bwheels which should solve build issues that users face.

Have not looked into testing this with conda python, only with the python that cibuildwheel will use.

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #224 (bd1754d) into master (5842d4d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files          17       17           
  Lines        1627     1627           
=======================================
  Hits         1092     1092           
  Misses        535      535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5842d4d...bd1754d. Read the comment docs.

.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/pre-commit.yaml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
.github/workflows/wheels.yml Outdated Show resolved Hide resolved
@mfeurer mfeurer merged commit 2e6f459 into master Feb 1, 2022
@mfeurer mfeurer deleted the build_wheels branch February 1, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants