Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check type of parent of conditions before writting to PCS files #247

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

dengdifan
Copy link
Contributor

Should solve pcs write related issues: #79 and #110

test/read_and_write/test_pcs_converter.py Outdated Show resolved Hide resolved
test/read_and_write/test_pcs_converter.py Outdated Show resolved Hide resolved
ConfigSpace/read_and_write/pcs_new.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #247 (ee0b6c3) into master (a8c5681) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   67.07%   66.72%   -0.35%     
==========================================
  Files          17       17              
  Lines        1637     1665      +28     
==========================================
+ Hits         1098     1111      +13     
- Misses        539      554      +15     
Impacted Files Coverage Δ
ConfigSpace/read_and_write/pcs_new.py 91.35% <100.00%> (+0.41%) ⬆️
ConfigSpace/read_and_write/json.py 80.00% <0.00%> (-5.26%) ⬇️
ConfigSpace/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c5681...ee0b6c3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants