Implement ConfigIDs and rename objective function budget to fidelity #66
Conversation
| if not hasattr(self, 'traj') or reset: | ||
| self.reset() | ||
| if verbose: | ||
| print("Initializing and evaluating new population...") |
There was a problem hiding this comment.
This caught my eye.
This traj could be confusing as its role of reset appears important.
Given we have moved to ResultItem and nice data classes, can we also store these traj like data variables better?
If you have a solution in mind, please feel free to raise an issue with it!
There was a problem hiding this comment.
This code block seems rather unituitive for me anyways. We are restriciting the user to always start a new run when calling the run method. I would personally prefer leaving this check out generally and leaving the users to reset the optimizer when ever they want. This would then be similar to the behavior in DEHB.
For the traj like classes I do agree to store them in a more principled fashion. I will think about it!
Implement ConfigID functionality by utilizing a new class
ConfigRepository.While there is still the possibility to extend the functionality e.g. for saving states, logs etc., I wanted to open this PR to get some continous feedback on my design.
Moreover I have renamed all budgets referring to the objective function to fidelity as we have discussed.
Please feel free to leave your comments/ideas on the changes!